[webkit-reviews] review granted: [Bug 236846] onpush/onpushsubscriptionchange exposed in Service Workers when Push API is disabled : [Attachment 452554] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sam Sneddon [:gsnedders]
<gsnedders at apple.com>'s request for review:
Bug 236846: onpush/onpushsubscriptionchange exposed in Service Workers when
Push API is disabled
https://bugs.webkit.org/show_bug.cgi?id=236846

Attachment 452554: Patch

https://bugs.webkit.org/attachment.cgi?id=452554&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 452554
  --> https://bugs.webkit.org/attachment.cgi?id=452554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452554&action=review

> Source/WebCore/Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl:28
> +    EnabledAtRuntime=PushAPIEnabled

Shouldn't this be `EnabledAtRuntime=ServiceWorkerEnabled&PushAPIEnabled` ?