[webkit-reviews] review granted: [Bug 236820] [WebAuthn] Support for conditional mediation : [Attachment 452551] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 236820: [WebAuthn] Support for conditional mediation
https://bugs.webkit.org/show_bug.cgi?id=236820

Attachment 452551: Patch

https://bugs.webkit.org/attachment.cgi?id=452551&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 452551
  --> https://bugs.webkit.org/attachment.cgi?id=452551
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452551&action=review

r=me

> Source/WebCore/Modules/credentialmanagement/BasicCredential.cpp:60
> +   
page->authenticatorCoordinator().isConditionalMediationAvailable(WTFMove(promis
e));

I think this might be simpler using the old:
if (auto* page = document.page())
    page->authenticator...<<ETC>>

Since nothing else happens in this method if page is nullptr.