[webkit-reviews] review granted: [Bug 236657] [WebAuthn] Add credentialID to _WKWebAuthenticationAssertionResponse and userHandle in getAllLocalAuthenticatorCredentials : [Attachment 452103] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 18 11:20:18 PST 2022


Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 236657: [WebAuthn] Add credentialID to
_WKWebAuthenticationAssertionResponse and userHandle in
getAllLocalAuthenticatorCredentials
https://bugs.webkit.org/show_bug.cgi?id=236657

Attachment 452103: Patch

https://bugs.webkit.org/attachment.cgi?id=452103&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 452103
  --> https://bugs.webkit.org/attachment.cgi?id=452103
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452103&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponse.mm:73
> +    return wrapper(_response->credentialID());

Is it possible for _response to be nullptr?


More information about the webkit-reviews mailing list