[webkit-reviews] review denied: [Bug 236728] Debug build failure after r246172: ASSERT_UNDER_CONSTEXPR_CONTEXT should work in constexpr contexts : [Attachment 452532] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has denied Mikhail R. Gadelha
<mikhail at igalia.com>'s request for review:
Bug 236728: Debug build failure after r246172: ASSERT_UNDER_CONSTEXPR_CONTEXT
should work in constexpr contexts
https://bugs.webkit.org/show_bug.cgi?id=236728

Attachment 452532: Patch

https://bugs.webkit.org/attachment.cgi?id=452532&action=review




--- Comment #12 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 452532
  --> https://bugs.webkit.org/attachment.cgi?id=452532
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452532&action=review

> Source/JavaScriptCore/wasm/WasmCompilationMode.h:47
> +    RELEASE_ASSERT(compilationMode == CompilationMode::LLIntMode

Um, but you can't use RELEASE_ASSERT in a constexpr function... you have to use
RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT.

In theory. I'm increasingly confused why compilers seem to sometimes care and
sometimes not....