[webkit-reviews] review granted: [Bug 236840] [CSS Container Queries] Match container queries correctly in non-rendered subtrees : [Attachment 452521] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 236840: [CSS Container Queries] Match container queries correctly in
non-rendered subtrees
https://bugs.webkit.org/show_bug.cgi?id=236840

Attachment 452521: Patch

https://bugs.webkit.org/attachment.cgi?id=452521&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 452521
  --> https://bugs.webkit.org/attachment.cgi?id=452521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452521&action=review

> Source/WebCore/style/ContainerQueryEvaluator.cpp:180
> +    // If the query container does not have a principal box ... then the
result of evaluating the size feature is unknown."

Nit: Either missing a leading " or maybe give the spec URL?