[webkit-reviews] review granted: [Bug 236823] Use async NSSharingServicePicker menu if available : [Attachment 452477] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 236823: Use async NSSharingServicePicker menu if available
https://bugs.webkit.org/show_bug.cgi?id=236823

Attachment 452477: Patch

https://bugs.webkit.org/attachment.cgi?id=452477&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 452477
  --> https://bugs.webkit.org/attachment.cgi?id=452477
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452477&action=review

> Source/WebKit/UIProcess/Cocoa/WKShareSheet.h:45
> +- (void)showPickerAsync:(NSSharingServicePicker *)picker
showRelativeToRect:(NSRect)presentationRect ofView:(WKWebView *)webView
completion:(void (^)(void))completionHandler;
>  @property (nonatomic, weak) id <WKShareSheetDelegate> delegate;

Nit: I think we usually put a blank line between the methods and the
@property(s).