[webkit-reviews] review granted: [Bug 236728] Debug build failure after r246172: ASSERT_UNDER_CONSTEXPR_CONTEXT should work in constexpr contexts : [Attachment 452517] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 18 07:57:42 PST 2022
Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 236728: Debug build failure after r246172: ASSERT_UNDER_CONSTEXPR_CONTEXT
should work in constexpr contexts
https://bugs.webkit.org/show_bug.cgi?id=236728
Attachment 452517: Patch
https://bugs.webkit.org/attachment.cgi?id=452517&action=review
--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 452517
--> https://bugs.webkit.org/attachment.cgi?id=452517
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=452517&action=review
> Source/WTF/wtf/Assertions.h:-364
> - WTFReportAssertionFailure(__FILE__, __LINE__, WTF_PRETTY_FUNCTION,
#assertion); \
I worry about a cross-platform change to fix a gcc-specific error.
More information about the webkit-reviews
mailing list