[webkit-reviews] review granted: [Bug 236655] [WGSL] Add enough of the AST for the simplest shaders : [Attachment 452379] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 18 06:43:54 PST 2022


Myles C. Maxfield <mmaxfield at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 236655: [WGSL] Add enough of the AST for the simplest shaders
https://bugs.webkit.org/show_bug.cgi?id=236655

Attachment 452379: Patch

https://bugs.webkit.org/attachment.cgi?id=452379&action=review




--- Comment #7 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 452379
  --> https://bugs.webkit.org/attachment.cgi?id=452379
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452379&action=review

> Source/WebGPU/WGSL/AST/TypeDecl.h:74
> +	   Vec2,

Surprising to see this rather than a pointer to an inner type.


More information about the webkit-reviews mailing list