[webkit-reviews] review granted: [Bug 236815] [macOS] Allow screen and window capture to be done in the GPU Process : [Attachment 452459] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 236815: [macOS] Allow screen and window capture to be done in the GPU
Process
https://bugs.webkit.org/show_bug.cgi?id=236815

Attachment 452459: Patch

https://bugs.webkit.org/attachment.cgi?id=452459&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 452459
  --> https://bugs.webkit.org/attachment.cgi?id=452459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452459&action=review

r=me with a small nit, once the bots are green

> Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:377
> +    ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER);

I think this can be ALWAYS_LOG_IF_POSSIBLE(LOGIDENTIFIER)

> Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:403
> +    ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER);

Ditto