[webkit-reviews] review granted: [Bug 236738] Web Inspector: [Flexbox] Add indicators for layout context in element tooltips : [Attachment 452467] Patch v1.2 - Remove label background/border changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 20:37:07 PST 2022


Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 236738: Web Inspector: [Flexbox] Add indicators for layout context in
element tooltips
https://bugs.webkit.org/show_bug.cgi?id=236738

Attachment 452467: Patch v1.2 - Remove label background/border changes

https://bugs.webkit.org/attachment.cgi?id=452467&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 452467
  --> https://bugs.webkit.org/attachment.cgi?id=452467
Patch v1.2 - Remove label background/border changes

View in context: https://bugs.webkit.org/attachment.cgi?id=452467&action=review

r=me, neat stuff!

> Source/WebCore/inspector/InspectorOverlay.cpp:1093
> +    Vector<String> layoutContextBubbleStrings;
> +    if (rendererIsFlexboxItem(*renderer))

NIT: I'd add a newline between these since `layoutContextBubbleStrings` is used
by more than just this `if`

> Source/WebCore/inspector/InspectorOverlayLabel.cpp:349
> +		   lineHeight

Style: Can we add a `,` at the end?


More information about the webkit-reviews mailing list