[webkit-reviews] review granted: [Bug 236748] Clean up / optimize call sites constructing vectors : [Attachment 452434] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 236748: Clean up / optimize call sites constructing vectors
https://bugs.webkit.org/show_bug.cgi?id=236748

Attachment 452434: Patch

https://bugs.webkit.org/attachment.cgi?id=452434&action=review




--- Comment #31 from Darin Adler <darin at apple.com> ---
Comment on attachment 452434
  --> https://bugs.webkit.org/attachment.cgi?id=452434
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452434&action=review

> Source/WebCore/css/calc/CSSCalcValue.cpp:72
>	   if (auto cssNode = createCSS(*node, style))
> -	       values.uncheckedAppend(cssNode.releaseNonNull());
> -    }
> -    values.shrinkToFit();
> -    return values;
> +	       return cssNode.releaseNonNull();
> +	   return nullptr;

return createCSS(*node, style);