[webkit-reviews] review denied: [Bug 236818] Add percent decoding to Scroll to Text Fragment parsing. : [Attachment 452453] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 236818: Add percent decoding to Scroll to Text Fragment parsing.
https://bugs.webkit.org/show_bug.cgi?id=236818

Attachment 452453: Patch

https://bugs.webkit.org/attachment.cgi?id=452453&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 452453
  --> https://bugs.webkit.org/attachment.cgi?id=452453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452453&action=review

Needs tests.

> Source/WTF/wtf/Vector.h:753
> +	   removeFirst();

This is a very slow operation in a Vector.  takeLast is O(1) but this is O(n). 
If you need this, use a Deque, but you probably don't.	It looks like you're
already using a Deque.

> Source/WebCore/dom/FragmentDirectiveParser.cpp:106
> +	       if (prefix)

nit: if (auto prefix = ...)
Then it's in the scope of the if statement.