[webkit-reviews] review granted: [Bug 236806] Refactor share menu item presentation : [Attachment 452436] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 15:20:45 PST 2022


Aditya Keerthi <akeerthi at apple.com> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 236806: Refactor share menu item presentation
https://bugs.webkit.org/show_bug.cgi?id=236806

Attachment 452436: Patch

https://bugs.webkit.org/attachment.cgi?id=452436&action=review




--- Comment #4 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 452436
  --> https://bugs.webkit.org/attachment.cgi?id=452436
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452436&action=review

> Source/WebCore/PAL/pal/spi/mac/NSSharingServicePickerSPI.h:31
> + at interface NSSharingServicePicker (Internal)

Nit: "Staging" is a more accurate name for the category.

> Source/WebCore/PAL/pal/spi/mac/NSSharingServicePickerSPI.h:-44
> -- (void)getMenuWithCompletion:(void(^)(NSMenu *))completion;

I think this deletion will cause open source builds to fail,
`getMenuWithCompletion:` is still used in `WebContextMenuProxyMac`.


More information about the webkit-reviews mailing list