[webkit-reviews] review denied: [Bug 236748] Clean up / optimize call sites constructing vectors : [Attachment 452413] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 236748: Clean up / optimize call sites constructing vectors
https://bugs.webkit.org/show_bug.cgi?id=236748

Attachment 452413: Patch

https://bugs.webkit.org/attachment.cgi?id=452413&action=review




--- Comment #23 from Darin Adler <darin at apple.com> ---
Comment on attachment 452413
  --> https://bugs.webkit.org/attachment.cgi?id=452413
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452413&action=review

Need to upload a fixed version

> Source/JavaScriptCore/parser/VariableEnvironment.cpp:222
> -    Compact variables = WTF::map(env, [this](auto& key) ->
PackedRefPtr<UniquedStringImpl> {
> +    auto variables = WTF::map(env, [this](auto& key) ->
PackedRefPtr<UniquedStringImpl> {

I feel guilty pushing for auto here since Eric explained how he doesn’t like
it.

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:2460
> +	   for (unsigned i = 0; i < length; !!i) {

!!i