[webkit-reviews] review granted: [Bug 236502] WebGL GPUP: Crash when running fast/mediastream/getUserMedia-to-canvas-1.html : [Attachment 452365] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 11:17:25 PST 2022


Eric Carlson <eric.carlson at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 236502: WebGL GPUP: Crash when running
fast/mediastream/getUserMedia-to-canvas-1.html
https://bugs.webkit.org/show_bug.cgi?id=236502

Attachment 452365: Patch

https://bugs.webkit.org/attachment.cgi?id=452365&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 452365
  --> https://bugs.webkit.org/attachment.cgi?id=452365
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452365&action=review

>> Source/WebCore/platform/VideoFrame.h:56
>>	virtual bool isCV() const { return false; }
> 
> The CV abbreviation is a bit obscure here.

It seems fine to me, and it won't be the first time we've used it, e.g.
GraphicsContextGLCV, PixelBufferConformerCV, GraphicsContextGLCVCocoa


More information about the webkit-reviews mailing list