[webkit-reviews] review requested: [Bug 236655] [WGSL] Add enough of the AST for the simplest shaders : [Attachment 452379] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 17 09:48:15 PST 2022
Robin Morisset <rmorisset at apple.com> has asked for review:
Bug 236655: [WGSL] Add enough of the AST for the simplest shaders
https://bugs.webkit.org/show_bug.cgi?id=236655
Attachment 452379: Patch
https://bugs.webkit.org/attachment.cgi?id=452379&action=review
--- Comment #6 from Robin Morisset <rmorisset at apple.com> ---
Created attachment 452379
--> https://bugs.webkit.org/attachment.cgi?id=452379&action=review
Patch
- Moved kind() methods from using a field to being virtual.
- Added missing TypeDecls
- Fixed style nits
- Applied Sam's suggestions
More information about the webkit-reviews
mailing list