[webkit-reviews] review granted: [Bug 236742] [WebGPU] Add a playground example target : [Attachment 452275] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 04:46:55 PST 2022


Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 236742: [WebGPU] Add a playground example target
https://bugs.webkit.org/show_bug.cgi?id=236742

Attachment 452275: Patch

https://bugs.webkit.org/attachment.cgi?id=452275&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 452275
  --> https://bugs.webkit.org/attachment.cgi?id=452275
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452275&action=review

> Source/WebGPU/CommandLinePlayground/main.swift:29
> +autoreleasepool {

why does this have to be in an autoreleasepool?

> Source/WebGPU/CommandLinePlayground/main.swift:36
> +    var _ = WGPUTextureDescriptorViewFormats(chain: WGPUChainedStruct(next:
nil, sType: WGPUSType(rawValue:
WGPUSTypeExtended_TextureDescriptorViewFormats.rawValue)), viewFormatsCount: 0,
viewFormats: nil)

let?


More information about the webkit-reviews mailing list