[webkit-reviews] review granted: [Bug 236683] [XCBuild] Use native build phases to copy PAL's headers : [Attachment 452285] Native PAL Headers via build rules + a legacy-only script phase, v2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 236683: [XCBuild] Use native build phases to copy PAL's headers
https://bugs.webkit.org/show_bug.cgi?id=236683

Attachment 452285: Native PAL Headers via build rules + a legacy-only script
phase, v2

https://bugs.webkit.org/attachment.cgi?id=452285&action=review




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 452285
  --> https://bugs.webkit.org/attachment.cgi?id=452285
Native PAL Headers via build rules + a legacy-only script phase, v2

View in context: https://bugs.webkit.org/attachment.cgi?id=452285&action=review

> Source/WebCore/PAL/Configurations/PAL.xcconfig:51
> +PRIVATE_HEADERS_FOLDER_PATH_legacy = /usr/local/include/pal_flattened;

This is a temporary directory, correct? I feel like there must be a more
appropriate place for intermediate files.