[webkit-reviews] review denied: [Bug 236717] Resync web-platform-tests/paint-timing from upstream : [Attachment 452211] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 16 11:03:24 PST 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Noam Rosenthal
<noam at webkit.org>'s request for review:
Bug 236717: Resync web-platform-tests/paint-timing from upstream
https://bugs.webkit.org/show_bug.cgi?id=236717

Attachment 452211: Patch

https://bugs.webkit.org/attachment.cgi?id=452211&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 452211
  --> https://bugs.webkit.org/attachment.cgi?id=452211
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452211&action=review

>
LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-backgroun
d-size.html:21
> +<script src="../../../../../resources/testharness.js"></script>
> +<script src="../../../../../resources/testharnessreport.js"></script>

These don't seem right. Did you use the script to import? The tests are run via
the http server so no need to fix up paths.


More information about the webkit-reviews mailing list