[webkit-reviews] review granted: [Bug 236683] [XCBuild] Use native build phases to copy PAL's headers : [Attachment 452143] Native PAL Headers via build rules v2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 236683: [XCBuild] Use native build phases to copy PAL's headers
https://bugs.webkit.org/show_bug.cgi?id=236683

Attachment 452143: Native PAL Headers via build rules v2

https://bugs.webkit.org/attachment.cgi?id=452143&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 452143
  --> https://bugs.webkit.org/attachment.cgi?id=452143
Native PAL Headers via build rules v2

Supporting two different code paths until we completely drop the legacy build
system support seems potentially troublesome. I did not think through this
patch enough to have a feel of how likely it is to break the build in just one
build system when making changes.