[webkit-reviews] review granted: [Bug 236336] Copy sub grid track sizes from the parent grid : [Attachment 452074] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Matt Woodrow
<mattwoodrow at apple.com>'s request for review:
Bug 236336: Copy sub grid track sizes from the parent grid
https://bugs.webkit.org/show_bug.cgi?id=236336

Attachment 452074: Patch

https://bugs.webkit.org/attachment.cgi?id=452074&action=review




--- Comment #7 from Dean Jackson <dino at apple.com> ---
Comment on attachment 452074
  --> https://bugs.webkit.org/attachment.cgi?id=452074
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452074&action=review

> Source/WebCore/rendering/GridLayoutFunctions.cpp:102
> +    return !isOrthogonalParent(grid, parent) ? direction : (direction ==
ForColumns ? ForRows : ForColumns);

Nit: I think this would read better as a positive test

return isOrthogonalParent ? (direction == ForColumns ? ForRows : ForColumns) :
direction;

But that's a minor opinion.