[webkit-reviews] review granted: [Bug 236672] Web Inspector: [Cocoa] Reentrancy in WebKit::WebInspectorUIProxy::open : [Attachment 452097] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 236672: Web Inspector: [Cocoa] Reentrancy in
WebKit::WebInspectorUIProxy::open
https://bugs.webkit.org/show_bug.cgi?id=236672

Attachment 452097: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=452097&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 452097
  --> https://bugs.webkit.org/attachment.cgi?id=452097
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=452097&action=review

rs=me

> Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:406
> +	       WTFLogAlways("WebInspectorUIProxy::platformBringToFront -
Inspected and inspector windows did not match while opening inspector. Falling
back to detached inspector. Inspected page had window: %s",
inspectedPage()->platformWindow() ? "YES" : "NO");

Do we _always_ want/need to log this?

Also, maybe we should use the `Inspector` log channel (e.g. `LOG(Inspector,
...);`)?