[webkit-reviews] review granted: [Bug 236660] Add a new rule to decide if a font is used only for icons : [Attachment 452085] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 236660: Add a new rule to decide if a font is used only for icons
https://bugs.webkit.org/show_bug.cgi?id=236660

Attachment 452085: Patch

https://bugs.webkit.org/attachment.cgi?id=452085&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 452085
  --> https://bugs.webkit.org/attachment.cgi?id=452085
Patch

Seems reasonable! One quick question, though — is there a reason we require
valid (non-empty) glyphs for all characters in the Arabic glyph range, rather
than one or more? (Perhaps we can include an explanation for that in the
ChangeLog)