[webkit-reviews] review granted: [Bug 236546] Refactor logic for writing selected text in image overlays to the pasteboard : [Attachment 451944] Rebase on trunk

[bugzilla-daemon at webkit.org]

Megan Gardner <megan_gardner at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 236546: Refactor logic for writing selected text in image overlays to the
pasteboard
https://bugs.webkit.org/show_bug.cgi?id=236546

Attachment 451944: Rebase on trunk

https://bugs.webkit.org/attachment.cgi?id=451944&action=review




--- Comment #3 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 451944
  --> https://bugs.webkit.org/attachment.cgi?id=451944
Rebase on trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=451944&action=review

> Source/WebCore/editing/Editor.cpp:1450
> +	   if (action == CopyAction && !isSelectionInImageOverlay)

I'm a bit confused, because this seems like it used to work for selections in
overlays, but now it won't? The logic just isn't lining up for me.