[webkit-reviews] review granted: [Bug 235981] Copy PDF.js in WebCore.framework bundle at build-time : [Attachment 452064] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 15 11:27:31 PST 2022


Alexey Proskuryakov <ap at webkit.org> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 235981: Copy PDF.js in WebCore.framework bundle at build-time
https://bugs.webkit.org/show_bug.cgi?id=235981

Attachment 452064: Patch

https://bugs.webkit.org/attachment.cgi?id=452064&action=review




--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 452064
  --> https://bugs.webkit.org/attachment.cgi?id=452064
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452064&action=review

> Source/WebCore/Makefile:5
> +	mkdir -p $@

Do we need to quote this, or anything else, in case of spaces in the path?


More information about the webkit-reviews mailing list