[webkit-reviews] review granted: [Bug 236631] Change the canonical unit for time category from ms to s. : [Attachment 451999] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 15 06:03:17 PST 2022


Darin Adler <darin at apple.com> has granted Joonghun Park
<jh718.park at samsung.com>'s request for review:
Bug 236631: Change the canonical unit for time category from ms to s.
https://bugs.webkit.org/show_bug.cgi?id=236631

Attachment 451999: Patch

https://bugs.webkit.org/attachment.cgi?id=451999&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 451999
  --> https://bugs.webkit.org/attachment.cgi?id=451999
Patch

I am really surprised that this behavior is not tested by any WPT test.
Assuming this can affect browser interoperability, we need to get something
into WPT. Or maybe this only affects the legacy CSS object model and that is
not well tested in WPT?

If this does only affect the legacy CSS object model then I wonder what the
odds are that this breaks some existing content accidentally relying on this.
How does this behave in other web browsers?


More information about the webkit-reviews mailing list