[webkit-reviews] review denied: [Bug 232936] [GTK] When building introspection files, add CMAKE_C_FLAGS to the compiler flags. : [Attachment 443793] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has denied Alexander Kanavin
<alex.kanavin at gmail.com>'s request for review:
Bug 232936: [GTK] When building introspection files, add CMAKE_C_FLAGS to the
compiler flags.
https://bugs.webkit.org/show_bug.cgi?id=232936

Attachment 443793: Patch

https://bugs.webkit.org/attachment.cgi?id=443793&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 443793
  --> https://bugs.webkit.org/attachment.cgi?id=443793
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443793&action=review

Hi, thanks for your patch. Hm, it sure seems like the right thing to do, so I
suppose we should try it. That said, this seems very familiar. Pretty sure
we've discussed this before at some point, likely years ago. I wonder if this
will surface some unexpected problem. Oh well, only one way to find out!

r- is only because you've failed the style bot due to the "No new tests
(OOPS!)."

> Source/JavaScriptCore/ChangeLog:3
> +	   When building introspection files, add CMAKE_C_FLAGS to the compiler
flags.

[GTK] When building introspection files, add CMAKE_C_FLAGS to the compiler
flags.

> Source/WebKit/ChangeLog:3
> +	   When building introspection files, add CMAKE_C_FLAGS to the compiler
flags.

[GTK] When building introspection files, add CMAKE_C_FLAGS to the compiler
flags.

> Source/WebKit/ChangeLog:8
> +	   No new tests (OOPS!).

You can simply remove this line in order to pass the style bot. Your change
doesn't require adding new tests.

> Source/JavaScriptCore/PlatformGTK.cmake:74
> +	   COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations\
${CMAKE_C_FLAGS} LDFLAGS=

Can you write it without a backslash as CFLAGS="-Wno-deprecated-declarations
${CMAKE_C_FLAGS}"?