[webkit-reviews] review granted: [Bug 236480] [css-transforms] properly handle interpolation of non-invertible matrices : [Attachment 451945] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 236480: [css-transforms] properly handle interpolation of non-invertible
matrices
https://bugs.webkit.org/show_bug.cgi?id=236480

Attachment 451945: Patch

https://bugs.webkit.org/attachment.cgi?id=451945&action=review




--- Comment #10 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 451945
  --> https://bugs.webkit.org/attachment.cgi?id=451945
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451945&action=review

Looks good to me, with a couple nits.

> Source/WebCore/platform/graphics/transforms/TransformOperations.cpp:99
> +bool TransformOperations::shouldFallbackToDiscreteAnimation(const
TransformOperations& from, const LayoutSize& boxSize) const

Super nit: Fallback => FallBack because "fall back" is the verb form and
"fallback" is the noun.

> Source/WebCore/platform/graphics/transforms/TransformOperations.h:66
> +	   return std::any_of(m_operations.begin(), m_operations.end(),
[](RefPtr<TransformOperation> op) {

Hrm. Can RefPtr<TransformOperation> be replaced with auto? I would use
"operation" instead of "op" here, because "op" can also mean operand.