[webkit-reviews] review granted: [Bug 236621] [libpas] compact pointers should load payload via memcpy : [Attachment 451957] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 14 17:00:32 PST 2022


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 236621: [libpas] compact pointers should load payload via memcpy
https://bugs.webkit.org/show_bug.cgi?id=236621

Attachment 451957: Patch

https://bugs.webkit.org/attachment.cgi?id=451957&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 451957
  --> https://bugs.webkit.org/attachment.cgi?id=451957
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451957&action=review

r=me.  Since EWS is misbehaving, please do a local build and smokes test run if
you haven't already done so.

> Source/bmalloc/ChangeLog:8
> +	   ASan found that we are loading 8bytes which can potentially be
overflown.

nit: "8bytes" => "8 bytes".  "overflown" => "overflowed".


More information about the webkit-reviews mailing list