[webkit-reviews] review denied: [Bug 44862] Make the caret more visible on any background : [Attachment 451935] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied  review:
Bug 44862: Make the caret more visible on any background
https://bugs.webkit.org/show_bug.cgi?id=44862

Attachment 451935: Patch

https://bugs.webkit.org/attachment.cgi?id=451935&action=review




--- Comment #49 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 451935
  --> https://bugs.webkit.org/attachment.cgi?id=451935
Patch

Before we go further down this road, I think we have to re-think the approach.
Ultimately, the answer of "what is the color of this pixel" means re-running
the entire painting logic, which you're starting to implement here.
Implementing a 2nd version of an algorithm that already exists is not a
sustainable approach.

If we really think this is important enough to fix, I think it either needs to
use the (possibly expensive) snapshotting approach, or do something very
simple.