[webkit-reviews] review granted: [Bug 236595] testapi should handle a missing testapiScripts directory cleaner : [Attachment 451912] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 236595: testapi should handle a missing testapiScripts directory cleaner
https://bugs.webkit.org/show_bug.cgi?id=236595

Attachment 451912: Patch

https://bugs.webkit.org/attachment.cgi?id=451912&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 451912
  --> https://bugs.webkit.org/attachment.cgi?id=451912
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451912&action=review

r=me

> Source/JavaScriptCore/API/tests/testapi.mm:2839
> +    if (![resolvePathToScripts()
checkResourceIsReachableAndReturnError:nil]) {
> +	   NSLog(@"File URL to testapiScripts: %@", resolvePathToScripts());
> +	   checkResult(@"File URL to `testapiScripts` isn't reachable is the
directory in place?", false);
> +	   return;
> +    }
> +

How about always showing 

NSLog(@"File URL to testapiScripts: %@", resolvePathToScripts());

and doing,

checkResult(@"File URL to `testapiScripts` isn't reachable is the directory in
place?", [resolvePathToScripts() checkResourceIsReachableAndReturnError:nil]);