[webkit-reviews] review granted: [Bug 236217] REGRESSION(r195447): [GTK] document.activeElement not set on mouse click : [Attachment 451875] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 14 06:50:31 PST 2022


Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 236217: REGRESSION(r195447): [GTK] document.activeElement not set on mouse
click
https://bugs.webkit.org/show_bug.cgi?id=236217

Attachment 451875: Patch

https://bugs.webkit.org/attachment.cgi?id=451875&action=review




--- Comment #12 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 451875
  --> https://bugs.webkit.org/attachment.cgi?id=451875
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451875&action=review

> Source/WebCore/html/HTMLAnchorElement.cpp:105
> +#if !(PLATFORM(GTK) || PLATFORM(WPE))

I would guard this with #if PLATFORM(COCOA) instead, since I suspect other
non-Apple ports want our behavior.


More information about the webkit-reviews mailing list