[webkit-reviews] review granted: [Bug 236570] Cache an entire attribute QualifiedName when parsing HTML, not just its local name AtomString : [Attachment 451841] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 236570: Cache an entire attribute QualifiedName when parsing HTML, not just
its local name AtomString
https://bugs.webkit.org/show_bug.cgi?id=236570

Attachment 451841: Patch

https://bugs.webkit.org/attachment.cgi?id=451841&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 451841
  --> https://bugs.webkit.org/attachment.cgi?id=451841
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451841&action=review

> Source/WebCore/html/parser/HTMLNameCache.h:38
> +    ALWAYS_INLINE static AtomString makeTagName(const Vector<UChar,
inlineCapacity>& string)

Can this take a Span<UChar> instead? Should be just as fast, although we’d need
to test.

> Source/WebCore/html/parser/HTMLNameCache.h:44
> +    ALWAYS_INLINE static QualifiedName makeAttributeQualifiedName(const
Vector<UChar, inlineCapacity>& string)

Ditto.

> Source/WebCore/html/parser/HTMLNameCache.h:50
> +    ALWAYS_INLINE static AtomString makeAttributeValue(const Vector<UChar,
inlineCapacity>& string)

Ditto.

> Source/WebCore/html/parser/HTMLNameCache.h:67
> +    ALWAYS_INLINE static AtomString makeAtomString(const Vector<UChar,
inlineCapacity>& string)

Ditto.

> Source/WebCore/html/parser/HTMLNameCache.h:89
> +    ALWAYS_INLINE static QualifiedName makeQualifiedName(const Vector<UChar,
inlineCapacity>& string)

Ditto.

> Source/WebCore/html/parser/HTMLNameCache.h:134
> +    using QualifiedNameCache =
std::array<RefPtr<QualifiedName::QualifiedNameImpl>, capacity>;

Why is this RefPtr<Impl> instead of just QualifiedName?