[webkit-reviews] review granted: [Bug 236567] Make StructureMemoryManager alignment assert a RELEASE_ASSERT : [Attachment 451831] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 13 11:43:41 PST 2022
Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 236567: Make StructureMemoryManager alignment assert a RELEASE_ASSERT
https://bugs.webkit.org/show_bug.cgi?id=236567
Attachment 451831: Patch
https://bugs.webkit.org/attachment.cgi?id=451831&action=review
--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 451831
--> https://bugs.webkit.org/attachment.cgi?id=451831
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review
r=me
> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85
> + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap &&
((g_jscConfig.startOfStructureHeap & ~structureIDMask) ==
g_jscConfig.startOfStructureHeap));
let's also release assert it's not null.
More information about the webkit-reviews
mailing list