[webkit-reviews] review granted: [Bug 234069] A FormData constructed in the form's submit event listener shouldn't include the submitter : [Attachment 451822] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreu Botella
<andreu at andreubotella.com>'s request for review:
Bug 234069: A FormData constructed in the form's submit event listener
shouldn't include the submitter
https://bugs.webkit.org/show_bug.cgi?id=234069

Attachment 451822: Patch

https://bugs.webkit.org/attachment.cgi?id=451822&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 451822
  --> https://bugs.webkit.org/attachment.cgi?id=451822
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451822&action=review

r=me except we need a patch with a corrected ChangeLog. So please don’t commit
this without fixing that. Also please consider my comment about the new test.

> LayoutTests/fast/forms/image/multiple-image-inputs.html:6
> +	 description("Multiple image inputs should work correctly.");

We’re missing a change log entry for this test and its expected result. That
would be in LayoutTests/ChangeLog.

Also wondering why we need our own WebKit-specific test for this. Could we have
added this testing to WPT?