[webkit-reviews] review granted: [Bug 236531] [macOS] Use system window and screen picker when available : [Attachment 451757] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 236531: [macOS] Use system window and screen picker when available
https://bugs.webkit.org/show_bug.cgi?id=236531

Attachment 451757: Patch

https://bugs.webkit.org/attachment.cgi?id=451757&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 451757
  --> https://bugs.webkit.org/attachment.cgi?id=451757
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451757&action=review

r=me with nit

> Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:151
> +    RunLoop::main().dispatch([self, strongSelf = RetainPtr { self }, session
= RetainPtr { session }]() mutable {

We shouldn't use RunLoop::main().dispatch() from WebCore code, because it will
dispatch to the wrong thread on iOS/WK1. Just use runOnMainThread(). It's a
known problem that this pattern is super confusing; apologies!

> Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:159
> +    RunLoop::main().dispatch([self, strongSelf = RetainPtr { self }, session
= RetainPtr { session }]() mutable {

Ditto.