[webkit-reviews] review granted: [Bug 236528] [run-webkit-tests] Do not try and read from /dev/null : [Attachment 451749] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 236528: [run-webkit-tests] Do not try and read from /dev/null
https://bugs.webkit.org/show_bug.cgi?id=236528

Attachment 451749: Patch

https://bugs.webkit.org/attachment.cgi?id=451749&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 451749
  --> https://bugs.webkit.org/attachment.cgi?id=451749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451749&action=review

> Tools/ChangeLog:9
> +	   While writing to /dev/null is well defined, reading from it is not.
Do not

I didn't know this. What is the source of this information?

That said, the patch removes more code than it adds, and webkitpy tests pass,
so it's good.