[webkit-reviews] review granted: [Bug 229780] Fixes for build-webkit --minimal : [Attachment 451742] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Philip Chimento
<philip.chimento at gmail.com>'s request for review:
Bug 229780: Fixes for build-webkit --minimal
https://bugs.webkit.org/show_bug.cgi?id=229780

Attachment 451742: Patch

https://bugs.webkit.org/attachment.cgi?id=451742&action=review




--- Comment #31 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 451742
  --> https://bugs.webkit.org/attachment.cgi?id=451742
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451742&action=review

r=me with nits. Honestly you might want to do a non-unified with the minimal
build as well.

> Source/WebCore/html/ColorInputType.cpp:42
> +#include "ElementChildIterator.h"

This still valid? I don't see that referenced in this cpp?

> Source/WebCore/inspector/agents/InspectorCanvasAgent.h:29
> +#include "Frame.h"

There's already a forward declaration of Frame here.

> Source/WebCore/inspector/agents/InspectorNetworkAgent.h:37
> +#include "SharedBuffer.h"

This looks like it can be forward declared.