[webkit-reviews] review granted: [Bug 236518] Redirect shadow realm console output to page's ConsoleClient : [Attachment 451743] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Griego
<jgriego at igalia.com>'s request for review:
Bug 236518: Redirect shadow realm console output to page's ConsoleClient
https://bugs.webkit.org/show_bug.cgi?id=236518

Attachment 451743: Patch

https://bugs.webkit.org/attachment.cgi?id=451743&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 451743
  --> https://bugs.webkit.org/attachment.cgi?id=451743
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451743&action=review

r=mews, thanks for taking my suggestions! =D

> LayoutTests/inspector/shadow-realm-console.html:26
> +	       async test(resolve, reject) {

NIT: please remove the `resolve, reject` since those are not provided when
using an `async test` :)

> LayoutTests/inspector/shadow-realm-console.html:40
> +	       async test(resolve, reject) {

ditto (:26)