[webkit-reviews] review granted: [Bug 236469] [WebAuthn] Access group not set in add query for importLocalAuthenticatorCredential : [Attachment 451702] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 236469: [WebAuthn] Access group not set in add query for
importLocalAuthenticatorCredential
https://bugs.webkit.org/show_bug.cgi?id=236469

Attachment 451702: Patch

https://bugs.webkit.org/attachment.cgi?id=451702&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 451702
  --> https://bugs.webkit.org/attachment.cgi?id=451702
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451702&action=review

r=me

> Source/WebKit/ChangeLog:9
> +	   In the patch adding support for setting accessGroup, previously did
not properly set

Suggestion: In Bug 236311 we added support setting accessGroup, but did not
properly set it on the addQuery. This patch fixes that.

> Tools/ChangeLog:14
> +	   * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

Really nice that you managed to create a test to protect this behavior!