[webkit-reviews] review granted: [Bug 236364] [WebAuthn] Modify getAllLocalAuthenticatorCredentials according to internal needs : [Attachment 451459] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 236364: [WebAuthn] Modify getAllLocalAuthenticatorCredentials according to
internal needs
https://bugs.webkit.org/show_bug.cgi?id=236364

Attachment 451459: Patch

https://bugs.webkit.org/attachment.cgi?id=451459&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 451459
  --> https://bugs.webkit.org/attachment.cgi?id=451459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451459&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:348
> ++ (void)setUsernameForLocalCredentialWithGroup:(NSString *)group
credential:(NSData *)credentialID username: (NSString *)username

Nit: I think we would usually name this something like
'setUsernameForLocalCredentialWithGroupAndID:'

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:553
> ++ (NSData *)exportLocalAuthenticatorCredentialWithGroup:(NSString *)group
credential:(NSData *)credentialID error:(NSError **)error

Ditto: "WithGroupAndID"