[webkit-reviews] review granted: [Bug 236510] Inject custom styles into PDF.js to make it look like PDFKit : [Attachment 451703] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 11 09:07:04 PST 2022


Tim Horton <thorton at apple.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 236510: Inject custom styles into PDF.js to make it look like PDFKit
https://bugs.webkit.org/show_bug.cgi?id=236510

Attachment 451703: Patch

https://bugs.webkit.org/attachment.cgi?id=451703&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 451703
  --> https://bugs.webkit.org/attachment.cgi?id=451703
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451703&action=review

> Source/WebCore/html/PDFDocument.h:51
> +    RefPtr<HTMLIFrameElement> m_iframe;

“m_iFrame” I would imagine given the type’s capitalization, but check what we
use elsewhere.


More information about the webkit-reviews mailing list