[webkit-reviews] review granted: [Bug 236356] Support remote video frames in WebRTC video pipeline : [Attachment 451694] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 236356: Support remote video frames in WebRTC video pipeline
https://bugs.webkit.org/show_bug.cgi?id=236356

Attachment 451694: Patch

https://bugs.webkit.org/attachment.cgi?id=451694&action=review




--- Comment #14 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 451694
  --> https://bugs.webkit.org/attachment.cgi?id=451694
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451694&action=review

Good, a bit to improve later in our overall architecture.
few nits

> Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:71
> +RemoteVideoFrameIdentifier
RemoteVideoFrameObjectHeap::createRemoteVideoFrame(Ref<WebCore::MediaSample>&&
frame)

maybe don't add this.
see the call site.

> Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:100
> +	       remoteIdentifier =
videoFrameObjectHeap->createRemoteVideoFrame(sample.releaseNonNull());

Use the same pattern as
RemoteGraphicsContextGL::paintCompositedResultsToMediaSample()

> Source/WebKit/Shared/ThreadSafeObjectHeap.h:192
> +template<typename Identifier, typename HeldType>

don't add this, it's a bit redundant and hard to use correctly.