[webkit-reviews] review denied: [Bug 234902] Order Web Inspector reference pages by column : [Attachment 448446] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 11 00:40:33 PST 2022


Tim Nguyen (:ntim) <ntim at apple.com> has denied Jon Davis <jond at apple.com>'s
request for review:
Bug 234902: Order Web Inspector reference pages by column
https://bugs.webkit.org/show_bug.cgi?id=234902

Attachment 448446: Patch

https://bugs.webkit.org/attachment.cgi?id=448446&action=review




--- Comment #3 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 448446
  --> https://bugs.webkit.org/attachment.cgi?id=448446
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448446&action=review

>
Websites/webkit.org/wp-content/themes/webkit/archive-web_inspector_page.php:159
> +	       column-count: 2;

You might want to define a column-width value as well. Right now, this isn't
responsive at small sizes, and you have 2 tiny columns (instead of 1 as
currently implemented).

This also needs clean up:
https://webkit-search.igalia.com/webkit/rev/38492c3c32c73865ca2d477ef03721b8739
9b24f/Websites/webkit.org/wp-content/themes/webkit/archive-web_inspector_page.p
hp#216-223


More information about the webkit-reviews mailing list