[webkit-reviews] review granted: [Bug 236456] Don't throw exception when controls are hidden : [Attachment 451577] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 236456: Don't throw exception when controls are hidden
https://bugs.webkit.org/show_bug.cgi?id=236456

Attachment 451577: Patch

https://bugs.webkit.org/attachment.cgi?id=451577&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 451577
  --> https://bugs.webkit.org/attachment.cgi?id=451577
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451577&action=review

> Source/WebCore/ChangeLog:1
> +2022-02-10  Eugene Mutavchi	<Ievgen_Mutavchi at comcast.com>

You're responsible for this patch, your name should be here. Eugene's one is
already in below.

> Source/WebCore/ChangeLog:3
> +	   Don't throw exception when controls are hidden

If the crash happens because controls are removed, then this title is
misleading.