[webkit-reviews] review requested: [Bug 235744] [XCBuild] WTF's headers are copied via a script and are invisible to the build system : [Attachment 451640] Fix install header paths, add SignedPtr.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 10 21:54:54 PST 2022


Elliott Williams <emw at apple.com> has asked  for review:
Bug 235744: [XCBuild] WTF's headers are copied via a script and are invisible
to the build system
https://bugs.webkit.org/show_bug.cgi?id=235744

Attachment 451640: Fix install header paths, add SignedPtr.h

https://bugs.webkit.org/attachment.cgi?id=451640&action=review




--- Comment #34 from Elliott Williams <emw at apple.com> ---
Created attachment 451640

  --> https://bugs.webkit.org/attachment.cgi?id=451640&action=review

Fix install header paths, add SignedPtr.h

Here's another attempt, incorporating
<https://bugs.webkit.org/show_bug.cgi?id=236471> and
<https://bugs.webkit.org/show_bug.cgi?id=236466>, which were also reverted.

The major new insight is that during `install` builds, the Copy Files phases
need to copy to an absolute path, not "Relative to Build Products". To do that,
they need to be based off a separate path variable than the main Headers phase,
so that they still copy relative to build products during engineering builds.


More information about the webkit-reviews mailing list