[webkit-reviews] review granted: [Bug 236415] [iOS] Add support for a "markup image" item in the callout bar when selecting a single image : [Attachment 451619] Actually fix iOS 15 build

[bugzilla-daemon at webkit.org]

Aditya Keerthi <akeerthi at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 236415: [iOS] Add support for a "markup image" item in the callout bar when
selecting a single image
https://bugs.webkit.org/show_bug.cgi?id=236415

Attachment 451619: Actually fix iOS 15 build

https://bugs.webkit.org/attachment.cgi?id=451619&action=review




--- Comment #6 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 451619
  --> https://bugs.webkit.org/attachment.cgi?id=451619
Actually fix iOS 15 build

View in context: https://bugs.webkit.org/attachment.cgi?id=451619&action=review

> Source/WebKit/ChangeLog:100
> +	   well, which does use custo menu items.

"custo"

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:248
> +struct ImageAnalysisMarkupResults {

Consider `ImageAnalysisMarkupData` or `ImageAnalysisMarkupInformation`, since
this really represents a single "result".

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:250
> +    RetainPtr<CGImageRef> result;

Consider renaming to `image`. That name is used below when unpacking this
struct.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:376
> +static RetainPtr<NSData> transcode(CGImageRef image, CFStringRef
typeIdentifier)

This helper can probably be reused in `provideDataForItem:` further down in
this file.