[webkit-reviews] review granted: [Bug 236459] [WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings from WebCore/WebKit : [Attachment 451588] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 236459: [WTF] Fix clang tidy bugprone-move-forwarding-reference static
analyzer warnings from WebCore/WebKit
https://bugs.webkit.org/show_bug.cgi?id=236459

Attachment 451588: Patch v1

https://bugs.webkit.org/attachment.cgi?id=451588&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 451588
  --> https://bugs.webkit.org/attachment.cgi?id=451588
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=451588&action=review

> Source/WTF/wtf/IteratorAdaptors.h:110
>  template<typename Transform, typename Iterator>
>  inline TransformIterator<Transform, Iterator>
makeTransformIterator(Transform&& transform, Iterator&& iter)
>  {
> -    return TransformIterator<Transform, Iterator>(WTFMove(transform),
WTFMove(iter));
> +    return TransformIterator<Transform,
Iterator>(std::forward<Transform>(transform), std::forward<Iterator>(iter));
>  }

We should dump this function and take advantage of deduction guides instead. OK
to fix it for now, though.