[webkit-reviews] review granted: [Bug 236342] Apply default sandbox to webpushd on Mac : [Attachment 451328] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Ben Nham <nham at apple.com>'s
request for review:
Bug 236342: Apply default sandbox to webpushd on Mac
https://bugs.webkit.org/show_bug.cgi?id=236342

Attachment 451328: Patch

https://bugs.webkit.org/attachment.cgi?id=451328&action=review




--- Comment #4 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 451328
  --> https://bugs.webkit.org/attachment.cgi?id=451328
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451328&action=review

R=me.

> Source/WebKit/webpushd/WebPushDaemonMain.mm:95
> +	   applySandbox();

It might be good to apply the sandbox first thing in WebPushDaemonMain to avoid
establishing connections to services which are blocked by the sandbox.