[webkit-reviews] review granted: [Bug 236374] Resync web-platform-tests/eventsource from upstream : [Attachment 451468] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 10 08:44:56 PST 2022


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 236374: Resync web-platform-tests/eventsource from upstream
https://bugs.webkit.org/show_bug.cgi?id=236374

Attachment 451468: Patch

https://bugs.webkit.org/attachment.cgi?id=451468&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 451468
  --> https://bugs.webkit.org/attachment.cgi?id=451468
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451468&action=review

>
LayoutTests/imported/w3c/web-platform-tests/eventsource/event-data-expected.txt
:-2
> -PASS EventSource: lines and data parsing

Is it expected for these 3 test expectations to be removed?

> LayoutTests/imported/w3c/web-platform-tests/eventsource/w3c-import.log:19
> +/LayoutTests/imported/w3c/web-platform-tests/eventsource/event-data.any.js

Since we have event-data.any.js, we should have some event-data.html files. It
seems every auto-generated html file is removed.
Please check what's happening before landing.


More information about the webkit-reviews mailing list